ForkMaster/netgen
1
0
Fork 0
mirror of https://github.com/NGSolve/netgen.git synced 2025-05-11 13:10:48 +05:00
Code Issues Packages Projects Releases Wiki Activity

Fix use of unitialized stlgeometry member in constructor

Browse Source 
stlgeometry is a private member of VisualSceneSTLGeometry/Meshing, and
can't point to any valid geometry when the constructor runs, so remove
any dereferences there.

Remove the misleading extern declaration of netgen::stlgeometry.
This commit is contained in:
Stefan Brüns 2022-07-13 12:09:39 +02:00
parent e8ec2b3550
commit 54705bc572
3 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libsrc/stlgeom/vsstl.cpp
View File

@ -21,7 +21,6 @@ namespace netgen
/* *********************** Draw STL Geometry **************** */
extern STLGeometry * stlgeometry;
DLL_HEADER extern shared_ptr<Mesh> mesh;
@ -33,8 +32,6 @@ VisualSceneSTLMeshing :: VisualSceneSTLMeshing ()
{
selecttrig = 0;
nodeofseltrig = 1;
stlgeometry->SetSelectTrig(selecttrig);
stlgeometry->SetNodeOfSelTrig(nodeofseltrig);
}
VisualSceneSTLMeshing :: ~VisualSceneSTLMeshing ()

4
libsrc/stlgeom/vsstl.hpp
View File

@ -13,7 +13,7 @@ namespace netgen
class NGGUI_API VisualSceneSTLGeometry : public VisualScene
{
NgArray<int> trilists;
class STLGeometry * stlgeometry;
class STLGeometry * stlgeometry = nullptr;
public:
VisualSceneSTLGeometry ();
@ -29,7 +29,7 @@ namespace netgen
{
NgArray<int> trilists;
int selecttrig, nodeofseltrig;
class STLGeometry * stlgeometry;
class STLGeometry * stlgeometry = nullptr;
public:
VisualSceneSTLMeshing ();

3
libsrc/visualization/stlmeshing.cpp
View File

@ -19,7 +19,6 @@ namespace netgen
/* *********************** Draw STL Geometry **************** */
extern STLGeometry * stlgeometry;
extern AutoPtr<Mesh> mesh;
@ -33,8 +32,6 @@ VisualSceneSTLMeshing :: VisualSceneSTLMeshing ()
{
selecttrig = 0;
nodeofseltrig = 1;
stlgeometry->SetSelectTrig(selecttrig);
stlgeometry->SetNodeOfSelTrig(nodeofseltrig);
}
VisualSceneSTLMeshing :: ~VisualSceneSTLMeshing ()